refactor: move Slack types to their own file#5224
refactor: move Slack types to their own file#5224santiagofn wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
📝 WalkthroughWalkthroughThis PR adds configuration files to ignore JetBrains IDE and Slack plans directories, and refactors Slack notifier type definitions into a dedicated types file while preserving existing functionality. ChangesGitignore Configuration
Slack Notifier Type Refactoring
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks pretty good, just some small nits. |
| @@ -0,0 +1,73 @@ | |||
| // Copyright 2019 Prometheus Team | |||
There was a problem hiding this comment.
Please use the header without date (example config/config.go)
| /amtool | ||
| /data/ | ||
| /vendor | ||
| .idea |
There was a problem hiding this comment.
There is no specific tools in .gitignore at the moment, I think this is intentional. So I would says this should be remove (same for the new .cursor/.gitignore)
3 participants
This is the first in a series of PRs that together implement threaded message support for the Slack notifier. The full picture is available in #5150.
Summary
Extracts the Slack notifier's internal types (
Notifier,request,attachment,slackResponse) fromslack.gointo a dedicatedtypes.gofile. No behavioral changes.